build: correct Jieba release license metadata#593
Merged
Conversation
Use the verified jieba-rs workspace license for generated Python artifact reports and support duplicate corrected crate versions. Co-authored-by: Dapeng Sun <sdp@apache.org>
JingsongLi
reviewed
Jul 23, 2026
JingsongLi
left a comment
JingsongLi
left a comment
Contributor
There was a problem hiding this comment.
scripts/release_licenses.py:125refers explicitly tojieba-rs-0.10.3.LICENSE, and the README also states that it only coversjieba-rs/jieba-macros 0.10.3; however,correction_html()inscripts/release_licenses.py:387directly uses this file for any version it resolves.- When I constructed metadata using
9.9.9, the script still successfully generated and applied the 0.10.3 license. In the future, when dependencies are upgraded, the license check will not require re-verification, potentially resulting in the silent generation of incorrect legal metadata. - It is recommended to add expected versions for each crate to
LicenseCorrectionand strictly validate them in repository-backed corrections; see the existingBundledComponent.crate_versionfor reference. (github.com)
Contributor
Author
|
Thanks for catching this. I’ve added explicit expected versions for both I also added a regression test using version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A (CI hotfix)
Fix release-license generation for Python artifacts after
paimon-ftindex-coreintroduced the transitivejieba-rsandjieba-macrosdependencies. Their crates.io packages do not include the workspace license file, soscripts/release_licenses.py --checkrejects the unresolved generic MIT placeholder.This extracts the focused legal-metadata fix from #591 and unblocks #571.
Brief change log
jieba-rsworkspace MIT license and document its pinned source.jieba-rsandjieba-macros.Tests
uv run --python 3.11 --no-project python -m unittest discover -s scripts/tests -p "test_*.py"cargo fetch --lockedpython3 scripts/release_licenses.py --check— validated 21 generated binary legal filescargo fmt --all -- --checkgit diff --checkAPI and Format
No public API or storage-format changes.
Documentation
Update
third-party-licenses/README.mdwith the pinned upstream source for the Jieba workspace license.